Hacker Newsnew | past | comments | ask | show | jobs | submit | drichelson's commentslogin

Author here. I'm paying more attention to GitHub than the comments here so please feel free to chime in there or ask any questions: https://github.com/dorklyorg/dorkly/discussions/40


Well GitHub has a pretty simple UI for editing files + submitting pull requests, so let's say it's a different UI.


Congrats on your success! The generally accepted definition of Feature Flags/Toggles seems to be this one: https://martinfowler.com/articles/feature-toggles.html


It's worth noting that there is no architectural limitation preventing an HA topology: multiple Dorkly servers can be deployed behind one or more load balancers for HA + lower latency where it matters (ie web and mobile apps).

If this is a limitation for anyone I'm happy to work with you on modifying the terraform module to support HA.


Random question while you're paying attention here. In the example repo, I was unable to find a file that _didn't_ say "This file is managed by terraform. Do not edit manually."

Which yaml files is one supposed to edit to actually modify the flags?


The example files are put in place by Terraform, so they will get overwritten next time `terraform apply` is run. You can of course change the example flag files as you're kicking the tires or testing out your app, but to really use the system you'll want to create new flags as documented here: https://github.com/dorklyorg/dorkly/wiki/3.-Common-Tasks#add... These new flags won't be managed by Terraform thus won't get reset to the default values.

This is good feedback. I'll clarify the comments


Fair point. I’m open to suggestions for a new name :)


I may or may not have grabbed the "LaunchOpenly" github organization name a while back. But I was intending to use it if anyone wanted to write an API-compatible Open Source clone of LD's APIs and flag-editing UI.


Correct: the flags live in a separate repo.


The PR is optional, but governance often requires documented peer approval for all production changes.

Flag changes can be pushed directly to the main branch with the correct repo permissions. When using the GitHub UI this involves just a little bit of typing and a few clicks.

>might as well just change the code at that point

If changing the code, running tests, building, and deploying is quicker and less risky then yes that makes more sense.


This seems like a reach. A nice benefit of having these server-owned configuration flags with a slick UI (like launchdarkly) is that they can be modified by people on the fly, and by people who may not even be engineers (like product managers). I imagine, that if the ask is that they instead get GitHub permissions, make a PR, wait for a review, etc, then perhaps you are not competing with launchdarkly. Though, having Git controlled server-owned configuration is still nice regardless.


Depends on the feature. In 99% of cases, I'd prefer an engineer to launch it and have the change tracked by source control


The sole reason I like feature flags is that I can quickly toggle off a change if it causes a problem. I'd hate to need to find someone to sign off on restoring service. Anything more than 1 or 2 clicks is just adding precious seconds to an outage. I've worked at places that gave broad implicit approval to developers to toggle away as needed. It worked well.


> I'd hate to need to find someone to sign off on restoring service.

In these shops, this gets handled via paging on-call engineers. The on-call is sometimes given more latitude if their actions are auditable.


Imagine being called out of bed to turn off a feature flag.

This is nonsense.


I have mostly seen developers in charge of changing flags, but there is also great value in empowering other roles to change flags (One example: sales people can unlock features as they sell them).

Thankfully GitHub has an easy web-based Pull Request process. It's not as simple as a custom UI, but could be used by non-engineers to change flags.


That's not a feature flag, that's a feature of the product. I would keep the 2 very distinct.


> sales people can unlock features as they sell them

That's a licensing thing, not a feature flag.


Not always. The most common counter example is beta features which customers opt into, controlled by the product team. It's too early for that to be part of the license, especially because pricing often hasn't been decided yet.

But there's also a surprisingly common situation with big customers who want to limit and control certain UI updates so they can ensure that employees are trained appropriately.


What's the difference? Either way you're turning on and off code that's already in the application. The only difference I can immediately see is that some people do feature flags as being on or off for the entire application instance, but I'm pretty sure you can do A/B testing with them at arbitrarily fine granularity and still count as a feature flag.


There are many different types of toggles of functionality. Not all of them are enabling code features. Well, they are but the why they are is what is at issue.

But it's all the same code under the covers. The functionality of what is enabled encoded into a license key - that's the same type of functionality as "does this deployment allow people to sign up by email" or "has this deployment enabled the super secret power user test functionality?"

But that's all under "if dataSource.toggle then {something}"

https://martinfowler.com/articles/feature-toggles.html


It’s a trusting and non-siloed org that gives the sales team access to the repos


LaunchDarkly - ONSITE in Oakland, California. Not currently hiring remotes workers Unable to sponsor visas at the moment.

Posting as an engineer who has been working here one year. This is a fantastic team and product. The business is very healthy- not just good growth, but very satisfied customers who are sticking around.

https://jobs.lever.co/launchdarkly

Eng interview process: Offsite coding task that we discuss in person when you're here + other technical and cultural chats.


Feature Flags FTW!


Pretty much. The issue now is, can I implement feature flags faster than I can implement the LaunchDarkly API?

I think I can do feature flags faster.


Can you implement analytics on top of those flags, plus a nice UI for nontechnical employees to toggle them faster? If you don't need those, then you probably aren't in their target audience.

Disclaimer: no relation, just playing devil's advocate.


This is exactly why they slightly pivoted to serving business teams.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: