Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I'm starting to run into the other end of this as a reviewer, and I hate it.

Stories full of nonsensical, clearly LLM-generated acceptance requirements containing implementation details which are completely unrelated to how the feature actually needs to work in our product. Fine, I didn't need them anyway.

PRs with those useless, uniformly-formatted LLM-generated descriptions which don't do what a PR description should do, with a half-arsed LLM attempt at summary of the code changes and links to the files in the PR description. It would have been nice if you had told me what your PR is for and what your intent as the author is, and maybe to call out things which were relevant to the implementation I might have "why?" questions about. But fine, I guess, being able to read, understand and evaluate the code is part of my job as a reviewer.

---- < the line

PRs littered with obvious LLM comments you didn't care enough to take out, where something minor and harmless, but _completely pointless_ has been added (as in if you'd read and understood what this code does, you'd have removed it), with an LLM comment left in above it AND at the end of the line, where it feels like I'm the first person to have tried to read and understand the code, and I feel like asking open-ended questions like "Why was this line added?" to get you to actually read and think about what's supposed to be your code, rather than a review comment explaining why it's not needed acting as a direct conduit from me to your LLM's "You're absolutely right!" response.



This absolutely has been my more recent frustration as well, specifically this:

> uniformly-formatted LLM-generated descriptions which don't do what a PR description should do, with a half-arsed LLM attempt at summary of the code changes and links to the files in the PR description. It would have been nice if you had told me what your PR is for and what your intent as the author is, and maybe to call out things which were relevant to the implementation I might have "why?" questions about.

If I want to see what the code changes do, I will read the code. I want your PR description to tell me things like:

- What the tradeoffs, if any, to this implementation are

- If there were potential other approaches you decided not to follow for XYZ reason so that I don't make a comment asking about it

- If there is more work to be done, and if so what it is

- Any impacts this change might have on other systems

- etc.

Sure, if you want to add a handful of sentences summarizing the change at a high level just to get me in context, that's fine, but again if I want to see what changed, I will go look at what changed.


Stupid question maybe, but are there no company guidelines? How can this be acceptable in the company culture?




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: